Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit PYTHONPATH when spawning workers. #148

Merged
merged 2 commits into from Nov 22, 2022
Merged

Inherit PYTHONPATH when spawning workers. #148

merged 2 commits into from Nov 22, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Nov 21, 2022

Resolves #146.

vstinner
vstinner reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to document the change in doc/changelog.rst?

You have to increase the pyperf version and add a new section. setup.py says:

update version in setup.py, pyperf/init.py and doc/conf.py

@vstinner
Copy link
Member

Ah, mention also that PYTHONPATH is inherited in --inherit-environ doc: doc/runner.rst.

@tjni
Copy link
Contributor Author

tjni commented Nov 21, 2022

I added an entry to the changelog and updated the documentation. The second commit prepares to release 2.6.0, but it can be dropped if you prefer to do that separately.

vstinner
vstinner approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update.

@vstinner vstinner merged commit d373c5e into psf:main Nov 22, 2022
@vstinner
Copy link
Member

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propagating PYTHONPATH in tests
2 participants
@tjni @vstinner