Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: Add CI for pypy series #159

Merged
merged 4 commits into from Apr 21, 2023
Merged

.github: Add CI for pypy series #159

merged 4 commits into from Apr 21, 2023

Conversation

corona10
Copy link
Member

@corona10
Copy link
Member Author

Well from pypy 3.9:

pyperf/pyperf/tests/test_timeit.py

Line 397 in 989d38f

self.assertTrue("Unknown character" in str(err))

-> unexpected character after line continuation character

@corona10 corona10 requested a review from vstinner April 21, 2023 05:45
hugovk
hugovk approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of minor suggestions.

.github/workflows/build.yml Outdated Show resolved Hide resolved
corona10 and others added 2 commits April 21, 2023 01:28
@corona10 @hugovk
Update .github/workflows/build.yml
f439e53 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@corona10
Address code review
61aa95d
@corona10 corona10 merged commit 1edbf2b into psf:main Apr 21, 2023
10 checks passed
@corona10 corona10 deleted the add_pypy branch April 21, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@corona10 @hugovk