Default timeout with retries

[foxx]

At the moment if I specify a timeout on a request, it does not attempt to retry.

It would be nice to be able to specify a default timeout that adhered to the default retry.

Here is the workaround I used for now;

requests.adapters.DEFAULT_RETRIES = 3

def fetch_page(url, timeout=3):
    c = 0
    last_exc = None
    while True:
        if c >= requests.adapters.DEFAULT_RETRIES:
            raise last_exc[0], last_exc[1], last_exc[2]
        try:
            return requests.get(url, timeout=timeout)
        except requests.Timeout, e:
            c+=1
            last_exc = sys.exc_info()
            logging.info("request timeout, retrying.. (%s/%s)" % ( c, 
                requests.adapters.DEFAULT_RETRIES))
        except Exception, e:
            raise

[Lukasa]

The intended API for retries is to use a different transport adapter:

import requests
from requests.adapters import HTTPAdapter

s = requests.Session()
s.mount('http://', HTTPAdapter(max_retries=3))
s.mount('https://', HTTPAdapter(max_retries=3))

You can then set the timeout on each request and this should work.

Does this look like what you want?

[foxx]

Ah that makes sense.. I couldn't figure this out from the docs, so perhaps the docs could be improved.. Although I'm not too sure how it would be explained

Thanks for the quick reply!

[Lukasa]

I'll have a think about how best to document this, but I might just end up writing a blog post about it and calling it a day.

Thanks for opening the issue, let me know if you need anything else! =)