raise RuntimeError when a single streamed request calls *iter methods th... #2241
Conversation
|
Let's have a subclass of |
| if self._content_consumed and isinstance(self._content, bool): | ||
| raise RuntimeError( | ||
| 'The content for this response was already consumed') | ||
| else: |
There was a problem hiding this comment.
No need for the else or the subsequent indentation, we won't get this far if we raise anyway.
|
EOFError? |
|
I think |
|
Thoughts on making whichever error name we choose multiply inherit from |
|
Yeah, I can accept that. And |
|
@tijko so could you update this PR to add the described exception to |
| @@ -89,3 +89,6 @@ class ChunkedEncodingError(RequestException): | |||
|
|
|||
| class ContentDecodingError(RequestException, BaseHTTPError): | |||
| """Failed to decode response content""" | |||
|
|
|||
| class StreamConsumedError(RequestException): | |||
There was a problem hiding this comment.
This needs to doubly inherit, like so:
class StreamConsumedError(RequestException, TypeError):
|
@sigmavirus24 looks like @tijko updated this as requested |
|
@kennethreitz looks good to me |
raise RuntimeError when a single streamed request calls *iter methods th...
In response to issue #2240, add a check to see if the content was "consumed"