Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idna requirement causing problems now idna 2.9 has been released. #5341

Closed
cjw296 opened this issue Feb 17, 2020 · 7 comments · Fixed by #5342
Closed

idna requirement causing problems now idna 2.9 has been released. #5341

cjw296 opened this issue Feb 17, 2020 · 7 comments · Fixed by #5342

Comments

@cjw296
Copy link
Contributor

cjw296 commented Feb 17, 2020

requrests pins idna to <2.9, which causes problems for pip now that 2.9 has been released.

Expected Result

projects that require requests to install cleanly when new second-point idna releases are made.

Actual Result

pip install .[dev]
...
Collecting idna>=2.0.0; extra == "secure"
...

ERROR: requests 2.22.0 has requirement idna<2.9,>=2.5, but you'll have idna 2.9 which is incompatible.
...

Then, when you try and use a setuptools entrypoint script:

    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (idna 2.9 (.../site-packages), Requirement.parse('idna<2.9,>=2.5'), {'requests'})

Reproduction Steps

See above.

System Information

Python 3.6
setuptools 45.2.0
pip 20.0.2
@cjw296
Copy link
Contributor Author

cjw296 commented Feb 17, 2020

See also #5337 and #5226

cjw296 added a commit to cjw296/requests that referenced this issue Feb 17, 2020
requests should trust dependent packages to do semver rather than artificially limiting version compatibility, which causes problems for pip.

Fixes psf#5341, psf#5337 and supercedes psf#5226.
@jacobtomlinson
Copy link

I am also experiencing this.

@cjw296
Copy link
Contributor Author

cjw296 commented Feb 18, 2020

@sethmlarson - any chance we could keep this issue open until the release goes out? Saves people reporting dupes...

@dralley
Copy link

dralley commented Feb 19, 2020

Yes please. A timeline on the new release would also be appreciated.

@nateprewitt
Copy link
Member

@dralley The release just went up onto PyPI.

@marcmaxson
Copy link

I resolved this by upgrading requests:
pip install requests --upgrade
from version 0.22 to 0.23, then dependency is idna<3,>=2.5

@tadejp
Copy link

tadejp commented Jan 11, 2021

I resolved this by upgrading requests:
pip install requests --upgrade
from version 0.22 to 0.23, then dependency is idna<3,>=2.5

this actually worked, thanks

@psf psf locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants