Fix iter_lines boundary bug when CRLF straddles two chunks #4629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Response.iter_lines
, if a\r\n
sequence (the only multi-character line boundary) straddles two chunks, the\r
and\n
are treated as two separate boundaries. Consequently,iter_lines
will yield one extra blank line, as an empty string.This addresses the issue by checking if a chunk ends with
\r
, and when appropriate, leaving the trailing line inpending
until the next chunk or EOF arrives.