Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow urllib 1.23 (part 2) #4671

Closed
wants to merge 1 commit into from
Closed

Allow urllib 1.23 (part 2) #4671

wants to merge 1 commit into from

Conversation

yan12125
Copy link
Contributor

@yan12125 yan12125 commented Jun 5, 2018

Follow-up of #4669

This eliminates the following warning:

$ python -c 'import requests'
/usr/lib/python3.6/site-packages/requests/__init__.py:80: RequestsDependencyWarning: urllib3 (1.23) or chardet (3.0.4) doesn't match a supported version!
  RequestsDependencyWarning)

@nateprewitt
Copy link
Member

Hmm, thanks @yan12125. This is why we usually do all of these steps at once. I may have jumped the gun this morning by merging th first PR. Rather than merge multiple follow ups, I think we’ll wait until we’re ready to release, likely next week to get everything wrapped up. I’ll try to go through this tonight and get things tidied with the urllib3 upgrade.

@nateprewitt nateprewitt closed this Jun 5, 2018
@yan12125
Copy link
Contributor Author

yan12125 commented Jun 5, 2018

No problem and thanks for the awesome work! Indeed most likely there will be more follow-ups - I just tried to run tests locally and some of them failed with urllib3 1.23. Not sure why Travis CI and AppVeyor didn't catch them, though.

@maxnbk
Copy link

maxnbk commented Jun 6, 2018

when would this get released to pypi?

@yan12125
Copy link
Contributor Author

yan12125 commented Jun 6, 2018

@maxnbk: According to this comment: #4673 (comment) - a week or so

@yan12125 yan12125 restored the allow-urllib-1.23-part-2 branch June 6, 2018 18:02
@yan12125 yan12125 deleted the allow-urllib-1.23-part-2 branch September 29, 2019 06:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants