New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synchronous mode to @curi/core #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Instead of manually selecting synchronous mode, Curi will default to synchronous, but switch to async if any route has an // sync
const routes = [
{ name: Home, path: '' },
{ name: Other, path: 'other' }
];
// async
const routes = [
{ name: Home, path: '' },
{
name: Other,
path: 'other'
match: {
initial: () => Promise.resolve('some value'),
response({ resolved }) => {...}
}
}
]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently response generation is asynchronous, which allows any
match.initial
andmatch.every
functions to run prior to emitting a new response.New New Behavior
When no route object has a
match.initial
ormatch.every
function, the router will automatically match routes synchronously.