Endless PubSub Recursion

[sjehuda]

Following our discussion in the groupchat, I attache a video that displays the issue.

psi_endlss_pubsub-2024-03-23_21.24.01.webm

[Neustradamus]

@sjehuda, @Ri0n, @Vitozz, @tehnick: It is linked to this historical XEP-0033 unlimited loop:

• Historical Service Discovery problem, an unlimited loop #632
• Infinite loop in Service Discovery (historical bug) #674
• XEP-0030: Service Discovery #707
• Endless PubSub Recursion #745
• Service discovery: Unexpected refresh psi-plus/main#807
• Crash in vCard of an user mucroom list when we click on the "Discovery" button #791

Screenshots:

• https://i.ibb.co/2kkmtPt/211104-psi-bug-service-discovery-problem-1.png
• https://i.ibb.co/fpdctxr/211104-psi-bug-service-discovery-problem-2.png

It is urgent to solve it...

[Ri0n]

I fixed it partially. should work when the second checkbox is set.
for a complete fix it's still necessary to detect a loop.

[Ri0n]

ah wait. it still does disco info on click. so should be ok even without checkbox.

[Neustradamus]

@Ri0n: Good job!

@sjehuda: Can you confirm the fix?

Linked commit:

• 9f3811b

Psi+ 1.5.1742:

• psi-plus/psi-plus-snapshots@9fef641

[sjehuda]

I fixed it partially. should work when the second checkbox is set.

@Neustradamus fixed is confirmed!

for a complete fix it's still necessary to detect a loop.

Yes. I noticed this too.

[Neustradamus]

Thanks to @Ri0n, another commit here:

• 5ba075a

Psi+ 1.5.1873:

• psi-plus/psi-plus-snapshots@6715a1b