Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated defined(%hash) with exists() #200

Merged
merged 1 commit into from Jan 6, 2016
Merged

Replace deprecated defined(%hash) with exists() #200

merged 1 commit into from Jan 6, 2016

Conversation

ginggs
Copy link
Contributor

@ginggs ginggs commented Jan 6, 2016

Documentation fails to build with perl 5.22 and reports the following error:

Can't use 'defined(%hash)' (Maybe you should just omit the defined()?)
at /build/psi4-0.3/doc/sphinxman/document_options_c.pl line 150.
doc/sphinxman/CMakeFiles/sphinxman.dir/build.make:106: recipe for
target 'doc/sphinxman/source/autodoc_abbr_options_c.rst' failed

Documentation fails to build with perl 5.22 and reports the following error:

Can't use 'defined(%hash)' (Maybe you should just omit the defined()?)
at /build/psi4-0.3/doc/sphinxman/document_options_c.pl line 150.
doc/sphinxman/CMakeFiles/sphinxman.dir/build.make:106: recipe for
target 'doc/sphinxman/source/autodoc_abbr_options_c.rst' failed
jturney added a commit that referenced this pull request Jan 6, 2016
Replace deprecated defined(%hash) with exists()
@jturney jturney merged commit c239165 into psi4:master Jan 6, 2016
@ginggs
Copy link
Contributor Author

ginggs commented Jan 7, 2016

@jturney: thanks for the merge!

We would have been warned of this problem for some time already if this line was not present:
https://github.com/psi4/psi4public/blob/master/doc/sphinxman/document_options_c.pl#L6
no warnings 'deprecated';

@ginggs ginggs deleted the patch-1 branch January 7, 2016 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants