-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting and add cargo fmt
to CI
#23
Comments
Should be used the nightly feature? It isn't a common-sense between projects, so I prefer to ask the main maintainer before doing stuff In my own projects I usually use:
and
What do you think? |
This seems like a good default. Although, I would like to have a separate issue/PR for clippy. I'll create one now. (Edit: it's #25).
What's the benefit of using nightly for |
Sure, will do this in different PR's as requested. About the nightly, it's not a convention. I use in my projects because, as some say, nightly supports more formatting options and produce prettier results. But it's unstable. If you prefer to use the stable option (default), that's fine. The verbose option is a personal pattern as well, will remove from the workflow |
That makes sense. We should use nightly for spressolisp too. |
Some of the code isn't formatted. Can be fixed by running
cargo fmt
.We should also enforce formatting by checking for formatting in CI. See this for an example.
The text was updated successfully, but these errors were encountered: