Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clippy to fix code issues and add it to CI #25

Open
2 tasks
Samyak2 opened this issue May 2, 2022 · 1 comment
Open
2 tasks

Use clippy to fix code issues and add it to CI #25

Samyak2 opened this issue May 2, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Samyak2
Copy link
Collaborator

Samyak2 commented May 2, 2022

cargo clippy currently emits nearly 50 warnings (and 1 error) on the current code base.

Tasks:

  • Run cargo clippy --all-targets --all-features and fix all code improvements suggested by it.
  • Add cargo clippy --all-targets --all-features -- -D warnings as a step to CI (after build, test, fmt, etc.) to ensure we have always have a codebase that satisfies clippy. The command was suggested here
@AugustoFKL
Copy link
Contributor

I'm correcting the Clippy issues. Just to let you know, I can't run the code itself and check everything. I'm relying on the tests.

So, if the tests don't cover something, I would appreciate it if you could check it!

This was referenced May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants