Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter 'data-show-img' doesn't work #6

Closed
juangar opened this issue Oct 1, 2013 · 1 comment
Closed

Parameter 'data-show-img' doesn't work #6

juangar opened this issue Oct 1, 2013 · 1 comment

Comments

@juangar
Copy link

juangar commented Oct 1, 2013

Despite setting 'data-show-img' to false the images are still showed. This happens in master branch.
I think the value comparison may be something like this: PSNC.chcontext.jQuery(container).attr("data-show-img") === 'false' (single quotes)
@olanowak
Copy link
Contributor

olanowak commented Oct 1, 2013

This was broken only in master. Repaired in fba09f2 Thanks for reporting :)

@olanowak olanowak closed this as completed Oct 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olanowak @juangar