This repository has been archived by the owner on Mar 7, 2024. It is now read-only.
Adding GLUT Shapes support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeef
reviewed
Apr 15, 2020
pspgl/glut.c
Outdated
| @@ -5,6 +5,7 @@ | |||
| #include <pspkerneltypes.h> | |||
| #include <pspctrl.h> | |||
| #include <psploadexec.h> | |||
| #include "glut_shapes.c" // Disable this if you don't want GLUT shapes support | |||
There was a problem hiding this comment.
.c files are not really intended for including ;)
There was a problem hiding this comment.
Remove this include, and instead, in /pspgl/Makefile,
append glut_shapes.c to glut target, like this:
libglut.a_OBJS = \
glut.o
glut_shapes.o
|
Sure thing |
|
Should be all good now |
Fixed warnings and added Makefile newline
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSPGL is missing GLUT shapes support, so this change adds it.
More details on supported shapes on https://github.com/iyenal/PSPGL-OpenGL-Shapes