Update to PHPUnit 10 #561
Update to PHPUnit 10 #561
Conversation
psalm-baseline.xml
Outdated
| <files psalm-version="5.7.7@e028ba46ba0d7f9a78bc3201c251e137383e145f"> | ||
| <file src="test/StoragelessTest/Session/LazySessionTest.php"> | ||
| <InvalidFunctionCall> | ||
| <code><![CDATA[($this->sessionLoader)()]]></code> |
There was a problem hiding this comment.
So, when I move from:
/** @var MakeSession&MockObject */
private MakeSession $sessionLoader;to
/** @var MakeSession&MockObject */
private MakeSession&MockObject $sessionLoader;Tests of course pass, and PSalm doesn't need the baseline.
But then phpcbf removed the DocBlock, and for some unbeknownst reason, PSalm breaks 😢
There was a problem hiding this comment.
I'd prioritize psalm over phocbf here: we can tell phpcbf to shut up here, and remove the baseline instead.
Rationale: this project should remain baseline -less.
psalm-baseline.xml
Outdated
| <files psalm-version="5.7.7@e028ba46ba0d7f9a78bc3201c251e137383e145f"> | ||
| <file src="test/StoragelessTest/Session/LazySessionTest.php"> | ||
| <InvalidFunctionCall> | ||
| <code><![CDATA[($this->sessionLoader)()]]></code> |
There was a problem hiding this comment.
I'd prioritize psalm over phocbf here: we can tell phpcbf to shut up here, and remove the baseline instead.
Rationale: this project should remain baseline -less.
Ocramius
added
enhancement
dependencies
|
@Ocramius I bet the infection fail is related to PHPUnit 10 completely dropped Can you tell me where to look to figure this out? |
|
That's on me to do: laminas/laminas-continuous-integration-action#130 |
No description provided.