Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artworks not showing after 8.4.0 Update #73

Open
amaduain opened this issue Mar 6, 2024 · 23 comments
Open

Artworks not showing after 8.4.0 Update #73

amaduain opened this issue Mar 6, 2024 · 23 comments
Assignees
Labels
enhancement New feature or request

Comments

@amaduain
Copy link

amaduain commented Mar 6, 2024

This is one of my favourites addons! but the artwork is not working anymore.
I updated to the latest version and I noticed that the artwork stopped working., I cannot see any cover for albums, searches or songs, after some investigation seems that the URLs have changed and now it is not able to show the pictures anymore
When everything worked the URL link of an artwork was this:

"https://www.mysqueezebox.com/public/imageproxy?u=https%3A%2F%2Fi.ytimg.com%2Fvi%2Fq1Vp ipwOxLE%2Fmaxresdefault.jpg"

Same album on the newest release 8.4.0 is like this:
"http://192.168.20.4:8123/imageproxy/https%3A%2F%2Fi.ytimg.com%2Fvi%2Fq1VpipwOxLE%2Fmax resdefault.jpg/image_300x300_f.jpg"

Notice that the URL is for my local home assistant (not real IP) on port 8123 and that URL is not working at all :-(

Any hints?

@pssc
Copy link
Owner

pssc commented Mar 6, 2024

hmmm this via ingress? What theme are you using might just be worth a quick rescan from scratch also. If it persists please log a issue, but in all my testing all this is ok I don’t have lms configured to use mysb for artwork anyway. This might be related to 8.4.0 deprecating use of mysqueezebox.com where possible.

Take it it all looks ok if you goto http://192.168.20.4:9000

@amaduain
Copy link
Author

amaduain commented Mar 6, 2024

You are right, I'm trying with other example, the URL passed to the browser is this:
http://192.168.20.4:8123/imageproxy/https%3A%2F%2Fi.scdn.co%2Fimage%2Fab67616d0000b2730fc3f45ec3c0037a882b1235/image.png
and it is not working:
image

image

But if I change the URL to port 9000 it is working:

http://192.168.20.4:9000/imageproxy/https%3A%2F%2Fi.scdn.co%2Fimage%2Fab67616d0000b2730fc3f45ec3c0037a882b1235/image.png

image

So it is a matter on do the proper redirect on the container
This is happening on the albums for the apps, Spotty, Youtube, etc, So I guess it uses dinamically the urls for the results, so the scan is not going to work in this case.

@pssc
Copy link
Owner

pssc commented Mar 6, 2024 via email

@amaduain
Copy link
Author

amaduain commented Mar 6, 2024 via email

@pssc
Copy link
Owner

pssc commented Mar 6, 2024 via email

@pssc
Copy link
Owner

pssc commented Mar 6, 2024

Is it configured as your default skin in LMS.

The good news is on my test system it all seems ok, which probably means this is totally fixable/repeatable if we can get the right info to me and we should be able to work round it in the meantime.

So what are you settings under
server->interface->performance->Artwork resizing
server->interface->Web Interface

@amaduain
Copy link
Author

amaduain commented Mar 8, 2024

Is it configured as your default skin in LMS.

The good news is on my test system it all seems ok, which probably means this is totally fixable/repeatable if we can get the right info to me and we should be able to work round it in the meantime.

So what are you settings under server->interface->performance->Artwork resizing server->interface->Web Interface

Thanks a lot for the help, I've been trying, and seems there is something not right with the material skin.
I did reinstall from scratch, deleting the LMS folder and so on, configured only the youtube app and did a search:
image

As you can see, the artwork is loaded properly
If I install the material skin and change to it, all the artwork is gone:
image

@amaduain
Copy link
Author

amaduain commented Mar 8, 2024

Seems that the direct access works fine on port 9000 (right), using HA portal (left) does not work
image

@pssc
Copy link
Owner

pssc commented Mar 8, 2024

LMS->server->interface->Web Interface
Should be Default,
HA-Addons-LMS-Skin to:-
material

server->interface->performance->Artwork resizing
separate helper process.

Clear cache restart browser.

@amaduain
Copy link
Author

amaduain commented Mar 8, 2024

Thanks a lot Phill, this is the setting that fixed the issue:
image

Kudos to your patience!!

@amaduain amaduain closed this as completed Mar 8, 2024
@pssc pssc self-assigned this Mar 8, 2024
@pssc pssc added the enhancement New feature or request label Mar 8, 2024
@pssc pssc reopened this Mar 8, 2024
@pssc
Copy link
Owner

pssc commented Mar 8, 2024

set server->interface->performance->Artwork resizing to separate process by default on new installs.

@baf
Copy link

baf commented Apr 24, 2024

@pssc - I am unfortunately also having this problem, even when using the settings above. The direct URL on port 9000 works, but ingress has incorrect/incomplete URLs for album art resulting in 404s.

I have my settings as follows, as suggested above:

  • Within LMS: Settings > Interface > Web Interface: Default
  • Within LMS: Settings > Advanced > Performance > Artwork resizing: Use Logitech Media Server resizing helper to resize artwork
  • In the HA add-on settings: Configuration > Skin: material

If it's helpful, I also use the NGINX Home Assistant SSL proxy add-on for HTTPS access to HA.

@pssc
Copy link
Owner

pssc commented Apr 24, 2024

Can you give an example of a broken url?

It seems all to be happy in my test config.

Things todo:-

Check LMS config
Check addon config and restart
Clear all caches and force reload pages in we browsers

@baf
Copy link

baf commented Apr 24, 2024

Thanks for the quick reply. Tried those (restart the add-on, different machines, browsers, private browsing), with same results unfortunately.

I can access LMS directly at http://ha.hostname:9000, and if I do, the album art URLs look like this:
http://ha.hostname:9000/imageproxy/http%3A%2F%2Fresources.tidal.com%2Fimages%2Fdaee3088%2Fdd9f%2F4bbd%2F8a88%2F36767eabccde%2F1080x1080.jpg/image_100x100_o

If I access LMS through ingress (https://ha.hostname/hassio/ingress/7222e6e9_lms), then the album art URLs look like this:
https://ha.hostname/imageproxy/http%3A%2F%2Fresources.tidal.com%2Fimages%2F3948376a%2Fcc40%2F40b4%2Fa97d%2F429f13d61973%2F1080x1080.jpg/image.jpg
That doesn't seem right, but I don't know what format the URLs are supposed to take in order to pass them through to LMS.

@pssc
Copy link
Owner

pssc commented Apr 24, 2024

Does it happen for local or is it Tidal only?

Does it work when not going through the nginx https proxy?

@baf
Copy link

baf commented Apr 24, 2024

Does it happen for local or is it Tidal only?

It's not just Tidal, as BBC Sounds also lacks any album art, but local albums work fine. Those URLs look like this:
https://ha.hostname/api/hassio_ingress/sqblct1HWR1dQALj9NgE2NaiL5xaFFO5vdZNyQLlFpY/music/83ceac23/cover_300x300_f

Does it work when not going through the nginx https proxy?

It does not work with Tidal or BBC Sounds even if I access HA directly at http://ha.hostname:8123.

@pssc
Copy link
Owner

pssc commented Apr 24, 2024

Ah yes ok each image url is generated by the plugin code, I will prod BBC Sounds into life on the test system and see what I can find.

@baf
Copy link

baf commented Apr 24, 2024

Thank you!

@amaduain
Copy link
Author

amaduain commented Apr 24, 2024 via email

@baf
Copy link

baf commented May 20, 2024

Hi @pssc - just wanted to see if you were able to reproduce this, or if there's anything I can do to help do so. Thanks!

@pssc
Copy link
Owner

pssc commented May 24, 2024

@baf I can replicate artwork missing from plugins but, Ii can't find a fix at present

@baf
Copy link

baf commented May 29, 2024

@pssc, understood, thanks. I don't have much experience to offer here but will poke around when I get a chance.

@ronluna
Copy link

ronluna commented Jun 24, 2024

I'm also having the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants