Skip to content

Commit

Permalink
reverts removal of parallel run from critest
Browse files Browse the repository at this point in the history
Signed-off-by: Paul S. Schweigert <paulschw@us.ibm.com>

As discussed in containerd#6903,
running ginkgo tests in parallel while trying to skip wasn't working.
However, now that
kubernetes-sigs/cri-tools#930 has fixed the
issue upstream, we can revert back to running our tests in parallel
with the skip.
  • Loading branch information
psschwei committed May 12, 2022
1 parent 9aa6725 commit 7300296
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions Vagrantfile
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,7 @@ EOF
fi
trap cleanup EXIT
ctr version
# TODO run in parallel, see https://github.com/containerd/containerd/issues/6903
critest --ginkgo.skip='HostIpc is true' --report-dir="${REPORT_DIR}"
critest --parallel=$[$(nproc)+2] --ginkgo.skip='HostIpc is true' --report-dir="${REPORT_DIR}"
SHELL
end

Expand Down
2 changes: 1 addition & 1 deletion script/setup/critools-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v1.24.0
v1.24.1
2 changes: 1 addition & 1 deletion script/setup/install-critools
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ set -eu -o pipefail
script_dir="$(cd -- "$(dirname -- "$0")" > /dev/null 2>&1; pwd -P)"

cd "$(go env GOPATH)"
go install github.com/onsi/ginkgo/ginkgo@v1.16.5
go install github.com/onsi/ginkgo/v2/ginkgo@v2.1.4

: "${CRITEST_COMMIT:=$(cat "${script_dir}/critools-version")}"
: "${DESTDIR:=""}"
Expand Down

0 comments on commit 7300296

Please sign in to comment.