Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pagination for the GitHub plugin #247

Closed
psss opened this issue Sep 23, 2021 · 0 comments · Fixed by #253
Closed

Implement pagination for the GitHub plugin #247

psss opened this issue Sep 23, 2021 · 0 comments · Fixed by #253
Labels
github plugins
Milestone
0.19

Comments

@psss
Copy link
Owner

psss commented Sep 23, 2021

Currently GitHub will not allow to fetch more than 100 items per call. We need to implement a full pagination to be able to fetch all issues. Should be quite simple to implement. Anyone interested? :) For now, I've only applied a simple hotfix in #246.
mikelolasagasti added a commit to mikelolasagasti/did that referenced this issue Oct 27, 2021
@mikelolasagasti
Add pagination support for GitHub, fixes psss#247
32f24e6 
Also, change from urllib to requests and some style changes.
@psss psss added this to the 0.19 milestone Oct 29, 2021
@psss psss linked a pull request Oct 29, 2021 that will close this issue
Add pagination support for GitHub, fixes #247 #253
Merged
@psss psss closed this as completed in #253 Oct 29, 2021
psss pushed a commit that referenced this issue Oct 29, 2021
@mikelolasagasti @psss
Add pagination support for GitHub, fixes #247
6106cde 
Also, change from urllib to requests and some style changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github plugins
Projects
None yet
Milestone
0.19
Development

Successfully merging a pull request may close this issue.

Add pagination support for GitHub, fixes #247 mikelolasagasti/did
1 participant
@psss