Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git repos expansion containing non-repo fails #41

Closed
dahaic opened this issue Sep 22, 2015 · 1 comment
Closed

git repos expansion containing non-repo fails #41

dahaic opened this issue Sep 22, 2015 · 1 comment
Assignees
Labels

Comments

@dahaic
Copy link

dahaic commented Sep 22, 2015

When path I specify as keeper of git repos [i.e. with /* expansion] contains non-repo directory, it fails with error complaining about GIT_DISCOVERY_ACROSS_FILESYSTEM not set.

 ERROR  fatal: Not a git repository (or any parent up to mount point /home)
 Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
 ERROR  Unable to check commits in '/home/dahaic/RH/git/tests/UPSTREAM'

If env variable is set, it fails nevertheless.

 ERROR  fatal: Not a git repository (or any of the parent directories): .git
 ERROR  Unable to check commits in '/home/dahaic/RH/git/tests/'

It would be nice to skip such directory and not fail.

@psss
Copy link
Owner

psss commented Sep 23, 2015

Agreed, it probably makes sense to give a warning in such case.

@psss psss added the bug label Sep 23, 2015
@psss psss self-assigned this Sep 23, 2015
@psss psss closed this as completed in c9af7fe Sep 23, 2015
psss pushed a commit to mweetman-redhat/did that referenced this issue Jan 30, 2023
I've noticed that the docstring mentions an argument,
and a Vagrant backend also uses one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants