Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config file to ~/.config/didrc #43

Closed
hrw opened this issue Sep 23, 2015 · 7 comments
Closed

Move config file to ~/.config/didrc #43

hrw opened this issue Sep 23, 2015 · 7 comments
Assignees
Labels

Comments

@hrw
Copy link
Contributor

hrw commented Sep 23, 2015

There are lot of dotfiles in $HOME. But more and more projects moved to using ~/.config ~/.local etc directories instead of creating new ones.

Did should follow.

@psss
Copy link
Owner

psss commented Sep 23, 2015

I see the point. But I'm a little bit hesitant to do this change as the plan is to include more data in that directory: Plugins subdirectory to allow custom user plugins, data for the local log plugin and possibly others. They do not fit all under the config umbrella. Plus it makes sense to keep them nicely together as they are closely related.

@calmrat
Copy link

calmrat commented Sep 23, 2015

I also don't see a strong reason to move to ~/.config or ~/.local

On Wed, Sep 23, 2015 at 12:21 PM, Petr Šplíchal notifications@github.com
wrote:

I see the point. But I'm a little bit hesitant to do this change as the
plan is to include more data in that directory: Plugins subdirectory to
allow custom user plugins, data for the local log plugin and possibly
others. They do not fit all under the config umbrella. Plus it makes sense
to keep them nicely together as they are closely related.


Reply to this email directly or view it on GitHub
#43 (comment).

@mcepl
Copy link

mcepl commented Sep 23, 2015

I see the point. But I'm a little bit hesitant to do this change as the plan is to include more data in that directory: Plugins subdirectory to allow custom user plugins, data for the local log plugin and possibly others. They do not fit all under the config umbrella. Plus it makes sense to keep them nicely together as they are closely related.

Sure, then what’s wrong with ~/.config/did/ directory? I think putting non-config file there is not that big heresy (of course, they should go in the ideal world to ~/.local/share/did/). Ideal is to use pyxdg, but yes that's additional dependency.

@calmrat
Copy link

calmrat commented Sep 23, 2015

although, the more I think about it... i also don't have strong feelings against it either. It would seem to keep things more organized.

Splitting config to ~/.config/did and non-config stuff to ~/.local/share/did/ seems to add a level of complication that we'd want to avoid; seems more effort than it is a bother to just use ~/.did/

Do we want to ever maintain support for non-linux environments? Seems like path decision might impact this... just food for thought though, I haven't had time to chew it. :)

@mcepl
Copy link

mcepl commented Sep 23, 2015

Do we want to ever maintain support for non-linux environments? Seems like path decision might impact this... just food for thought though, I haven't had time to chew it. :)

The only real advantage of pyxdg package is availability of XDG paths on Windows (or Mac OS X, I don’t know what's the situation there). You really don’t want to deal with those crazy paths on Windows! However, if we don't care about compatibility than just strings ~/.config/did/, ~/.cache/did/ (if we have any cache files), and ~/.local/share/did/ should be enough.

@psss
Copy link
Owner

psss commented Sep 23, 2015

I don't think it's worth separating the files into two or more directories, I like short paths and I don't find hidden files in home directory in any way obstructing. For those who prefer to keep the home directory clean the DID_CONFIG variable represents an easy way how to use a different location. I've adjusted docs to make this even more straightforward.

@psss psss closed this as completed in ac9dcfb Sep 23, 2015
@psss psss self-assigned this Sep 23, 2015
@psss psss added the wontfix label Sep 23, 2015
@mcepl
Copy link

mcepl commented Sep 23, 2015

Actually, DID_CONFIG is pretty good for fix, I guess. So, you have really not WONTFIXed it? ;) Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants