Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report bugs created with Patch keyword as patched #109

Merged
merged 1 commit into from Feb 10, 2017
Merged

Conversation

mfrodl
Copy link

@mfrodl mfrodl commented Oct 25, 2016

Currently, PatchedBugs only reports previously existing bugs to which the Patch keyword was added. Bugs to which the reporter added the keyword during their creation are not reported. By applying this commit, PatchedBugs will report such bugs as well.

Currently, PatchedBugs only reports previously existing bugs to which
the Patch keyword was added. Bugs to which the reporter added the
keyword during their creation are not reported. By applying this commit,
PatchedBugs will report such bugs as well.
@mfrodl
Copy link
Author

mfrodl commented Oct 25, 2016

Also, note that I had to use the new XMLRPC argument format (f1, o1, v1 etc.) because the old one which is currently used in did (field0-0-0, type0-0-0, value0-0-0 etc.) does not have sufficient expressive power. Most notably, the old style does not provide a way to express negation (keywords not changed to "Patch").

In order to prevent mixing old and new syntax, we should consider rewriting all the existing queries to use the new style as well.

mfrodl pushed a commit to mfrodl/did that referenced this pull request Oct 26, 2016
The old field names (field0-0-0, type0-0-0, value0-0-0 etc.) have been
replaced with the new ones (f1, o1, v1 etc.). The old syntax was unable
to express more complex queries which may be needed sometimes; for
instance see psss#109.
mfrodl pushed a commit to mfrodl/did that referenced this pull request Nov 14, 2016
The old field names (field0-0-0, type0-0-0, value0-0-0 etc.) have been
replaced with the new ones (f1, o1, v1 etc.). The old syntax was unable
to express more complex queries which may be needed sometimes; for
instance see psss#109.
@psss psss merged commit 463b3dc into psss:master Feb 10, 2017
psss added a commit that referenced this pull request Feb 10, 2017
@psss psss self-assigned this Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants