Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config option to accept full filepath #140

Merged
merged 1 commit into from Oct 1, 2019

Conversation

mnalband
Copy link

@mnalband mnalband commented Aug 8, 2017

Negative (file not found) examples to show what config filepath was used:

Without env variable:

(py2)[mnalband@mnalband work_repo]$ unset DID_DIR

Default config path:

(py2)[mnalband@mnalband work_repo]$ did
 ERROR  Unable to read the config file '/home/mnalband/.did/config'.

Only config filename:

(py2)[mnalband@mnalband work_repo]$ did --config config2
 ERROR  Unable to read the config file '/home/mnalband/.did/config2'.

Filepath and filename:

(py2)[mnalband@mnalband work_repo]$ did --config /tmp/config2
 ERROR  Unable to read the config file '/tmp/config2'.

With env variable:

(py2)[mnalband@mnalband work_repo]$ export DID_DIR=/tmp/did

Default config path:

(py2)[mnalband@mnalband work_repo]$ did
 ERROR  Unable to read the config file '/tmp/did/config'.

Only config filename:

(py2)[mnalband@mnalband work_repo]$ did --config config2
 ERROR  Unable to read the config file '/tmp/did/config2'.

Filepath and filename:

(py2)[mnalband@mnalband work_repo]$ did --config /tmp/config2
 ERROR  Unable to read the config file '/tmp/config2'.

Positive usage example with filepath and filename

(py2)[mnalband@mnalband work_repo]$ did --config /tmp/config 
Status report for the week 32 (2017-08-07 to 2017-08-13).

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 Maryna Nalbandian <mnalband@redhat.com>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

* Highlights

* Joy of the week

@psss psss self-assigned this Oct 1, 2019
psss added a commit that referenced this pull request Oct 1, 2019
@psss
Copy link
Owner

psss commented Oct 1, 2019

Looks good. Thanks for the improvement, Maryna. And sorry for the terrible response time ;-)

@psss psss merged commit 95e19bf into psss:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants