Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Gerrit data to the specified time #185

Merged
merged 1 commit into from Feb 6, 2019
Merged

Limit Gerrit data to the specified time #185

merged 1 commit into from Feb 6, 2019

Conversation

hferreiro
Copy link
Contributor

Previously, the Gerrit plugin would fetch all changes up to the current
date. This commits adds the 'since:' and 'until:' search operators to
limit data fetching to the specified time.

Previously, the Gerrit plugin would fetch all changes up to the current
date. This commits adds the 'since:' and 'until:' search operators to
limit data fetching to the specified time.
@psss psss self-assigned this Feb 6, 2019
@psss
Copy link
Owner

psss commented Feb 6, 2019

Thanks for the patch. Looks good. This should improve the performance. We still need to make some other changes to make it the limit work completely. For example I've noticed that in the reviewed changes there is this strange query:

reviewer:{0}+is:closed&q=reviewer:{0}+is:open

Which, when extended with since/until results in:

reviewer:login+is:closed&q=reviewer:login+is:open+since:2019-01-28+until:2019-02-04

But let's do the cleanup later. Going to merge.

psss added a commit that referenced this pull request Feb 6, 2019
@psss psss merged commit 3ae39e7 into psss:master Feb 6, 2019
psss added a commit to mweetman-redhat/did that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants