Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest invocation #299

Merged
merged 1 commit into from Feb 8, 2023
Merged

Fix pytest invocation #299

merged 1 commit into from Feb 8, 2023

Conversation

sandrobonazzola
Copy link
Contributor

py.test moved to pytest.

Signed-off-by: Sandro Bonazzola sbonazzo@redhat.com

@psss
Copy link
Owner

psss commented Feb 8, 2023

Looks good, thanks. Could you please update the commit message (no prefix, starting with capital) so that it's consistent with the rest and ready for release notes? Thanks.

py.test moved to pytest.

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
@sandrobonazzola
Copy link
Contributor Author

Looks good, thanks. Could you please update the commit message (no prefix, starting with capital) so that it's consistent with the rest and ready for release notes? Thanks.

done

@sandrobonazzola sandrobonazzola changed the title coverage: fix pytest invocation Fix pytest invocation Feb 8, 2023
@kwk
Copy link
Collaborator

kwk commented Feb 8, 2023

@psss I guess .travis.yml is not needed to be changed since we don't run travis jobs any longer, do we?

@psss
Copy link
Owner

psss commented Feb 8, 2023

Yes, we can drop .travis.yaml, good point.

Copy link
Collaborator

@kwk kwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this patch.

kwk added a commit to kwk/did that referenced this pull request Feb 8, 2023
According to psss#299 (comment) we're removing travis ci.
@psss psss self-assigned this Feb 8, 2023
@psss psss added the tests label Feb 8, 2023
@psss psss added this to the 0.20 milestone Feb 8, 2023
Copy link
Owner

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@psss psss merged commit f5b4816 into psss:main Feb 8, 2023
@sandrobonazzola sandrobonazzola deleted the coverage_fix branch February 8, 2023 16:52
psss pushed a commit to kwk/did that referenced this pull request Feb 8, 2023
According to psss#299 (comment)
we're removing travis ci.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants