Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Option #137

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Required Option #137

merged 2 commits into from
Feb 24, 2022

Conversation

PPP01
Copy link

@PPP01 PPP01 commented Feb 21, 2022

this adds an "required" option

Pull request for:
#133

@PPP01
Copy link
Author

PPP01 commented Feb 21, 2022

Sorry, i picked the wrong point for the branch, so it fails
I will redo anothe PR

@PPP01
Copy link
Author

PPP01 commented Feb 21, 2022

Now it should be fine

@@ -973,6 +975,7 @@
{placeholder}
{name}
{disabled}
required={required}
Copy link
Collaborator

@azmeuk azmeuk Feb 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be written just {required} (but this is a detail).

@pstanoev pstanoev merged commit 1de79e1 into pstanoev:master Feb 24, 2022
@PPP01 PPP01 deleted the required branch March 9, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants