Fixed minCharactersToSearch behavior with async #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the input is focused, the behavior is different if a
searchFunction
is defined or not. When not defined, the menu always open, independently ofminCharactersToSearch
, when defined, the menu nevers opens, independently ofminCharactersToSearch
.This patch does not change behavior when
searchFunction
is not defined, but when it is andminCharactersToSearch
is 0, then the menu opens when the input is focused.I am not sure this is what we want though, I think behavior probably should not be different wether
searchFunction
is defined or not.What do you think?