Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minCharactersToSearch behavior with async #161

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

azmeuk
Copy link
Collaborator

@azmeuk azmeuk commented Apr 14, 2022

Currently, when the input is focused, the behavior is different if a searchFunction is defined or not. When not defined, the menu always open, independently of minCharactersToSearch, when defined, the menu nevers opens, independently of minCharactersToSearch.

This patch does not change behavior when searchFunction is not defined, but when it is and minCharactersToSearch is 0, then the menu opens when the input is focused.

I am not sure this is what we want though, I think behavior probably should not be different wether searchFunction is defined or not.

What do you think?

@azmeuk azmeuk requested a review from pstanoev April 14, 2022 10:50
@pstanoev pstanoev merged commit bbb8f0a into pstanoev:master Apr 21, 2022
@pstanoev
Copy link
Owner

pstanoev commented Jun 1, 2022

We should look again at this.
IMO, the behavior should be different if searchFunction is defined or not.
If it is not, always open.
If searchFuncton is defined, open only if minCharactersToSearch=0.

We have also #172 which mentions this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants