Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

Ostinato does not automatically re-connect to Drone #333

Closed
pstavirs opened this issue Dec 25, 2020 · 1 comment
Closed

Ostinato does not automatically re-connect to Drone #333

pstavirs opened this issue Dec 25, 2020 · 1 comment

Comments

@pstavirs
Copy link
Owner

If Drone is killed by pressing Ctrl-C, Ostinato does not try to reconnect.

This might be expected behaviour - the auto-reconnect is possibly only for unexpected socket closures e.g. drone crashing. Need to check.

@pstavirs
Copy link
Owner Author

pstavirs commented Dec 27, 2020

A little bit of research reveals that currently when the client receives a socket error - QAbstractSocket::RemoteHostClosedError, the client does not attempt a reconnect.

This was added to handle cases where version incompatibility checks fail where we do not want to reconnect.

Also, it seems this same error is received irrespective of how drone exits - intentionally, gracefully or crashes out. This makes it impossible to distinguish between the cases on the client side, unless we add some other mechanism to detect the manner of drone exit.

@pstavirs pstavirs changed the title Ostinato does not automatically connect to Drone Ostinato does not automatically re-connect to Drone Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant