Skip to content

Commit

Permalink
[bugfix] Don't ignore the fact that offsetof is a keyword.
Browse files Browse the repository at this point in the history
  • Loading branch information
pstef committed Jul 30, 2016
1 parent ddd263d commit c470e5e
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 31 deletions.
18 changes: 11 additions & 7 deletions indent.c
Expand Up @@ -511,7 +511,10 @@ main(int argc, char **argv)
++ps.p_l_follow; /* count parens to make Healy happy */
if (ps.want_blank && *token != '[' &&
(ps.last_token != ident || proc_calls_space
|| (ps.its_a_keyword && (!ps.sizeof_keyword || Bill_Shannon))))
/* offsetof (1) is never allowed a space; sizeof (2) gets
* one iff -bs; all other keywords (>2) always get a space
* before lparen */
|| (ps.keyword + Bill_Shannon > 2)))
*e_code++ = ' ';
ps.want_blank = false;
if (ps.in_decl && !ps.block_init && !ps.dumped_decl_indent && !is_procname) {
Expand Down Expand Up @@ -541,19 +544,20 @@ main(int argc, char **argv)
ps.in_or_st = false; /* turn off flag for structure decl or
* initialization */
}
if (ps.sizeof_keyword)
ps.sizeof_mask |= 1 << ps.p_l_follow;
/* parenthesized type following sizeof or offsetof is not a cast */
if (ps.keyword == 1 || ps.keyword == 2)
ps.not_cast_mask |= 1 << ps.p_l_follow;
break;

case rparen: /* got a ')' or ']' */
rparen_count--;
if (ps.cast_mask & (1 << ps.p_l_follow) & ~ps.sizeof_mask) {
if (ps.cast_mask & (1 << ps.p_l_follow) & ~ps.not_cast_mask) {
ps.last_u_d = true;
ps.cast_mask &= (1 << ps.p_l_follow) - 1;
ps.want_blank = false;
} else
ps.want_blank = true;
ps.sizeof_mask &= (1 << ps.p_l_follow) - 1;
ps.not_cast_mask &= (1 << ps.p_l_follow) - 1;
if (--ps.p_l_follow < 0) {
ps.p_l_follow = 0;
diag3(0, "Extra %c", *token);
Expand Down Expand Up @@ -710,7 +714,7 @@ main(int argc, char **argv)
if (ps.last_token == rparen && rparen_count == 0)
ps.in_parameter_declaration = 0;
ps.cast_mask = 0;
ps.sizeof_mask = 0;
ps.not_cast_mask = 0;
ps.block_init = 0;
ps.block_init_level = 0;
ps.just_saw_decl--;
Expand Down Expand Up @@ -968,7 +972,7 @@ main(int argc, char **argv)
copy_id:
if (ps.want_blank)
*e_code++ = ' ';
if (troff && ps.its_a_keyword) {
if (troff && ps.keyword) {
e_code = chfont(&bodyf, &keywordf, e_code);
for (t_ptr = token; *t_ptr; ++t_ptr) {
CHECK_SIZE_CODE;
Expand Down
11 changes: 5 additions & 6 deletions indent_globs.h
Expand Up @@ -239,10 +239,10 @@ struct parser_state {
* char should be lined up with the / in / followed by * */
int comment_delta,
n_comment_delta;
int cast_mask; /* indicates which close parens close off
* casts */
int sizeof_mask; /* indicates which close parens close off
* sizeof''s */
int cast_mask; /* indicates which close parens potentially
* close off casts */
int not_cast_mask; /* indicates which close parens definitely
* close off something else than casts */
int block_init; /* true iff inside a block initialization */
int block_init_level; /* The level of brace nesting in an
* initialization */
Expand Down Expand Up @@ -312,8 +312,7 @@ struct parser_state {
* specially */
int decl_indent; /* column to indent declared identifiers to */
int local_decl_indent; /* like decl_indent but for locals */
int its_a_keyword;
int sizeof_keyword;
int keyword; /* the type of a keyword or 0 */
int dumped_decl_indent;
float case_indent; /* The distance to indent case labels from the
* switch statement */
Expand Down
35 changes: 17 additions & 18 deletions lexi.c
Expand Up @@ -66,13 +66,13 @@ struct templ {

struct templ specials[1000] =
{
{"switch", 1},
{"case", 2},
{"break", 0},
{"switch", 7},
{"case", 8},
{"break", 9},
{"struct", 3},
{"union", 3},
{"enum", 3},
{"default", 2},
{"default", 8},
{"int", 4},
{"char", 4},
{"float", 4},
Expand All @@ -88,14 +88,15 @@ struct templ specials[1000] =
{"void", 4},
{"const", 4},
{"volatile", 4},
{"goto", 0},
{"return", 0},
{"goto", 9},
{"return", 9},
{"if", 5},
{"while", 5},
{"for", 5},
{"else", 6},
{"do", 6},
{"sizeof", 7},
{"sizeof", 2},
{"offsetof", 1},
{0, 0}
};

Expand Down Expand Up @@ -230,8 +231,7 @@ lexi(void)
if (++buf_ptr >= buf_end)
fill_buffer();
}
ps.its_a_keyword = false;
ps.sizeof_keyword = false;
ps.keyword = 0;
if (l_struct && !ps.p_l_follow) {
/* if last token was 'struct' and we're not
* in parentheses, then this token
Expand All @@ -253,7 +253,7 @@ lexi(void)
/* Check if we have an "_t" in the end */
if (q_len > 2 &&
(strcmp(q + q_len - 2, "_t") == 0)) {
ps.its_a_keyword = true;
ps.keyword = 4; /* a type name */
ps.last_u_d = true;
goto found_auto_typedef;
}
Expand All @@ -278,12 +278,12 @@ lexi(void)
}
if (p->rwd) { /* we have a keyword */
found_keyword:
ps.its_a_keyword = true;
ps.keyword = p->rwcode;
ps.last_u_d = true;
switch (p->rwcode) {
case 1: /* it is a switch */
case 7: /* it is a switch */
return (swstmt);
case 2: /* a case or default */
case 8: /* a case or default */
return (casestmt);

case 3: /* a "struct" */
Expand All @@ -297,8 +297,9 @@ lexi(void)
case 4: /* one of the declaration keywords */
found_auto_typedef:
if (ps.p_l_follow) {
ps.cast_mask |= (1 << ps.p_l_follow) & ~ps.sizeof_mask;
break; /* inside parens: cast, param list or sizeof */
/* inside parens: cast, param list, offsetof or sizeof */
ps.cast_mask |= (1 << ps.p_l_follow) & ~ps.not_cast_mask;
break;
}
last_code = decl;
return (decl);
Expand All @@ -309,8 +310,6 @@ lexi(void)
case 6: /* do, else */
return (sp_nparen);

case 7:
ps.sizeof_keyword = true;
default: /* all others are treated like any other
* identifier */
return (ident);
Expand All @@ -337,7 +336,7 @@ lexi(void)
&& (ps.last_token == rparen || ps.last_token == semicolon ||
ps.last_token == decl ||
ps.last_token == lbrace || ps.last_token == rbrace)) {
ps.its_a_keyword = true;
ps.keyword = 4; /* a type name */
ps.last_u_d = true;
last_code = decl;
return decl;
Expand Down

0 comments on commit c470e5e

Please sign in to comment.