Index SUDOC values #507
Merged
Index SUDOC values #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for normalization. They will return nil. Instead just return the unprocessed call number if SUDOC. Tests
jlandiseigsti
approved these changes
May 10, 2024
| @@ -102,6 +105,10 @@ def dewey? | |||
| classification == 'DEWEY' | |||
| end | |||
|
|
|||
| def sudoc? | |||
| classification == 'SUDOC' | |||
There was a problem hiding this comment.
I like these shortcuts.
There was a problem hiding this comment.
Is there any possibility the returned case would ever be different (eg 'Sudoc')? I assume not, but just wanted to check.
There was a problem hiding this comment.
Hmm, good question. I would say no since the others don't do any case normalization. It's probably some standard for marc that they are always in uppercase, but I wouldn't be against adding case normalization to all of these to be safe.
Smullz622
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #406
Now indexing SUDOC values. The next step of this would be to start identifying what kind of processing needs done on these. We may want to set up a preview branch for this and have it do a full index. Then output a large subset of these for Ruth to look at.