Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update edition #2

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Update edition #2

merged 2 commits into from
Jun 2, 2020

Conversation

parasyte
Copy link
Contributor

@parasyte parasyte commented Jun 1, 2020

Updates much of the syntax to Rust 2018 edition.

  • Remove extern crate
  • Use new module naming convention
    • E.g. src/tui.rs instead of src/tui/mod.rs
  • Use pub(crate) visibility modifier where possible
  • Use crate:: or self:: path specifiers to reference modules within the crate.
    • This solves the ambiguity between the tui crate and the tui module, for example
  • Rename redundantly named submodules like tui::tui to tui::types
  • Directly use macros by full path
  • Update lalrpop to newest stable release
  • cargo fmt updated some minor syntax things, like removing redundant commas on some match arms.

@psurply psurply merged commit 8f3d30b into psurply:master Jun 2, 2020
@psurply
Copy link
Owner

psurply commented Jun 2, 2020

This change looks good to me. Thanks a lot!

@parasyte parasyte deleted the update-edition branch June 2, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants