Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(breaking) change requireIf(Not) to requiredIf(Not) #62

Closed
ksafranski opened this issue Nov 25, 2016 · 1 comment
Closed

(breaking) change requireIf(Not) to requiredIf(Not) #62

ksafranski opened this issue Nov 25, 2016 · 1 comment
Assignees
@ksafranski @psvet

Comments

@ksafranski
Copy link
Contributor

Since the property name is required (not require) it makes more sense if the property name and API uses the same convention for requiredIf and requiredIfNot.
@ksafranski ksafranski self-assigned this Nov 25, 2016
@ksafranski
Copy link
Contributor Author

Idea here: instead of creating a breaking change, and because the naming could be easily mismatched, add alias methods for requireIf and requireIfNot and then have them spit a warning message to the console requireIf should be requiredIf (and appropriate ...IfNot message) but allow them to still work.

May actually be a good idea to add this to the base require method as well just to ensure API consistency is more obvious to devs.

@psvet psvet mentioned this issue Jan 9, 2017
Merged
@psvet psvet closed this as completed in #65 Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ksafranski ksafranski

@psvet psvet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksafranski @psvet