Compose "full" example for components schema #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See src/examples/datalad-dataset-components/ContainerSE-DatasetWFiles.yaml It works in principle, but I was not yet able to get the description of an AnnexedFileSE's `distribution` to work (see comments inside). This is strange, because this part is more or less taken verbatim from the `datalad-dataset-version` schema, and `src/examples/datalad-dataset-version/DataladDatasetVersionSE-full.yaml` shows it to be working properly. As elaborated on inside, the JSON schema code generator does not include a class that is required for validation. However, it does reference it.
Include a patch that fixes a JSON schema generation problem that blocks progress for us.
Becomes possible after applying the linkml patch introduced in the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See src/examples/datalad-dataset-components/ContainerSE-DatasetWFiles.yaml
It works in principle, but I was not yet able to get the description of an AnnexedFileSE's
distributionto work (see comments inside).This is strange, because this part is more or less taken verbatim from the
datalad-dataset-versionschema, andsrc/examples/datalad-dataset-version/DataladDatasetVersionSE-full.yamlshows it to be working properly.As elaborated on inside, the JSON schema code generator does not include a class that is required for validation. However, it does reference it.
Update: I possible fix or workaround was found and is subject to review at linkml/linkml#1935
Update: I include linkml-patching now, and enabled the full example.