Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KBI0012: annex encryption & GPG pinentry #44

Merged
merged 3 commits into from May 5, 2023
Merged

Add KBI0012: annex encryption & GPG pinentry #44

merged 3 commits into from May 5, 2023

Conversation

mslw
Copy link
Contributor

@mslw mslw commented Apr 26, 2023

This short KBI is converted from my own notes. The origin was an issue on MacOS which was discussed during office hours at some point in March 2023 (and also demonstrated on our cluster).

@mslw mslw marked this pull request as ready for review April 26, 2023 17:12
.. index::
single: git-annex; encryption

KBI0012: Annex encryption & gpg pinentry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can make it more clear in the title that this KBI is about resolving an issue, and not, e.g., about how to set encryption up? Maybe its also useful to cross-reference your usecase in the handbook as a pointer: http://handbook.datalad.org/en/latest/usecases/encrypted_annex.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - updated.

mslw added 2 commits May 2, 2023 17:35
The intro explains that the KBI is about resolving a very specific
issue, and not about setting up encryption in general - for the
latter, the user is pointed to the Handbook use case.

Suggested-by: Adina Wagner <adina.wagner@t-online.de>
Makes it clear that the error is because there was no way to ask for
the passphrase.
@jsheunis
Copy link
Contributor

jsheunis commented May 3, 2023

LGTM!

Copy link
Contributor

@christian-monch christian-monch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thx!

@mih mih merged commit 7b2221e into main May 5, 2023
3 checks passed
@mih mih deleted the 0012 branch May 5, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants