Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out whether sanity check in Aux serialisation should be re-introduced #764

Closed
psychon opened this issue Nov 16, 2022 · 0 comments · Fixed by #767
Closed

Figure out whether sanity check in Aux serialisation should be re-introduced #764

psychon opened this issue Nov 16, 2022 · 0 comments · Fixed by #767

Comments

@psychon
Copy link
Owner

psychon commented Nov 16, 2022

I just noticed the following change in ecdc405 in xproto.rs and I feel like that is wrong. Since I don't have the time to investigate this right now, I am simply opening this ticket instead.

@@ -5548,7 +6920,7 @@ impl CreateWindowAux {
         result
     }
     fn serialize_into(&self, bytes: &mut Vec<u8>, value_mask: u32) {
-        assert_eq!(self.switch_expr(), value_mask, "switch `value_list` has an inconsistent discriminant");
+        let _ = value_mask;
         if let Some(background_pixmap) = self.background_pixmap {
             background_pixmap.serialize_into(bytes);
         }
@@ -6099,7 +7471,7 @@ impl ChangeWindowAttributesAux {
         result
     }
     fn serialize_into(&self, bytes: &mut Vec<u8>, value_mask: u32) {
-        assert_eq!(self.switch_expr(), value_mask, "switch `value_list` has an inconsistent discriminant");
+        let _ = value_mask;
         if let Some(background_pixmap) = self.background_pixmap {
             background_pixmap.serialize_into(bytes);
         }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant