Allow scanning of roms that do not have file extensions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextiley
changed the title
|
Looks great! Thank you for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xbox Live Arcade roms do not have file extensions. Playnite's built-in emulator profile for Xenia supports roms without file extensions by associating the emulator profile with the dummy
<none>extension.The default emulator profile:
At the moment, EmuLibrary does not handle these, and so XBLA roms are ignored when a scan is executed.
See https://github.com/JosefNemec/Playnite/blob/ef9effdd273f1448f05d53c3f5eacc5448d6f1ee/source/Playnite/Emulation/Emulators/Xenia/emulator.yaml#L8 for the default emulator profile configuration.
And here's the built-in scanner: https://github.com/JosefNemec/Playnite/blob/ef9effdd273f1448f05d53c3f5eacc5448d6f1ee/source/Playnite/Emulators/Scanner.cs#L907
This pull request ensures that both single and multi-file scanners consider roms without file extensions where the emulator profile is configured with extension
<none>.Successful import:
