Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall action improvements and minor fixes #7

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Uninstall action improvements and minor fixes #7

merged 1 commit into from
Jan 7, 2024

Conversation

alextiley
Copy link
Contributor

Improves the uninstall actions:

Multi-file rom types:

  • Fixes a minor bug where the primary rom file within the install directory was being deleted, but not the whole folder. The uninstall action will now clean up the entire folder.

Single and multi-file rom types:

  • The list of roms assigned to the game are now cleared after the uninstall is completed. This reverts the game back to it's pure "uninstalled" state.
  • If the rom to delete can no longer be found when triggering the uninstall action, then the game will now be marked as uninstalled regardless of whether the controller was able to delete the files or not. This ensures that the game installation state is correct. The message "{Game.Name} does not appear to be installed. Marking as uninstalled." is displayed to the user when this edge case arises. This would only really happen if the user deletes the file manually, or if they are sharing/syncing a Playnite instance between multiple devices.

@psychonic
Copy link
Owner

Looks good. Thanks!

@psychonic psychonic merged commit dcedc2a into psychonic:master Jan 7, 2024
@alextiley alextiley deleted the fix/improve-uninstall-actions branch January 10, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants