Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visual/VisualStim: Enable pixi updates when setting opacity #203

Merged
merged 4 commits into from Apr 9, 2021
Merged

visual/VisualStim: Enable pixi updates when setting opacity #203

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72e9fe5
visual/ShapeStim: drop adding opacity attribute in constructor
Oct 6, 2020
3d708d5
visual/VisualStim: mark opacity as needing pixi updates
Oct 6, 2020
987244e
Merge branch 'master' into bf#202--opacity
Mar 19, 2021
a002114
visual/MovieStim: drop set opacity attribute from constructor (no eff…
Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions js/visual/ShapeStim.js
View file
Open in desktop
Expand Up @@ -101,12 +101,6 @@ export class ShapeStim extends util.mix(VisualStim).with(ColorMixin, WindowMixin
1.0,
this._onChange(true, false)
);
this._addAttribute(
'opacity',
opacity,
1.0,
this._onChange(false, false)
);
}


Expand Down
2 changes: 1 addition & 1 deletion js/visual/VisualStim.js
View file
Open in desktop
Expand Up @@ -64,7 +64,7 @@ export class VisualStim extends util.mix(MinimalStim).with(WindowMixin)
'opacity',
opacity,
1.0,
this._onChange(false, false)
this._onChange(true, false)
);
this._addAttribute(
'depth',
Expand Down