Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Failing to render JS code from CodeComponents #3643

Merged
merged 1 commit into from Feb 25, 2021

Conversation

peircej
Copy link
Member

@peircej peircej commented Feb 25, 2021

Because code blocks were being listed as 'code' not 'extendedCode' they
were not sent to the correct js conversion (need snippet2js)

Because code blocks were being listed as 'code' not 'extendedCode' they
were not sent to the correct js conversion (need snippet2js)
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #3643 (accbe28) into release (c4101af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #3643   +/-   ##
========================================
  Coverage    43.20%   43.20%           
========================================
  Files          267      267           
  Lines        52751    52751           
  Branches      9100     9100           
========================================
+ Hits         22790    22792    +2     
+ Misses       27640    27639    -1     
+ Partials      2321     2320    -1     
Impacted Files Coverage Δ
psychopy/experiment/components/code/__init__.py 90.56% <ø> (ø)
psychopy/experiment/_experiment.py 52.50% <100.00%> (ø)
psychopy/web.py 36.53% <0.00%> (-1.29%) ⬇️
psychopy/app/connections/news.py 59.18% <0.00%> (+8.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4101af...accbe28. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 25, 2021

Coverage Status

Coverage increased (+0.004%) to 47.046% when pulling accbe28 on peircej:hotfix-codeCompJS into c4101af on psychopy:release.

@peircej peircej merged commit 7ad67b4 into psychopy:release Feb 25, 2021
@peircej peircej deleted the hotfix-codeCompJS branch February 26, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants