Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Initialise arabic reshaper with params to preserve harakats #5033

Merged
merged 1 commit into from Jul 22, 2022

Conversation

TEParsons
Copy link
Contributor

Applying changes from #4770 to Textbox as well as Textstim

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #5033 (ec07a26) into release (c53516d) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff            @@
##           release    #5033   +/-   ##
========================================
  Coverage    38.13%   38.13%           
========================================
  Files          307      307           
  Lines        61633    61638    +5     
  Branches     10752    10753    +1     
========================================
+ Hits         23504    23507    +3     
- Misses       36096    36098    +2     
  Partials      2033     2033           
Impacted Files Coverage Δ
psychopy/visual/textbox2/textbox2.py 78.99% <75.00%> (+0.05%) ⬆️
psychopy/logging.py 75.17% <0.00%> (-0.71%) ⬇️
psychopy/sound/transcribe.py 40.44% <0.00%> (-0.23%) ⬇️
psychopy/visual/window.py 62.44% <0.00%> (-0.15%) ⬇️
psychopy/colors.py 63.63% <0.00%> (+0.15%) ⬆️
psychopy/visual/movie3.py 62.27% <0.00%> (+0.73%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@peircej peircej merged commit 640de80 into psychopy:release Jul 22, 2022
@TEParsons TEParsons deleted the release-textbox-bidi branch August 10, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants