BF: Sound files were playing forever if duration set to <0.5s #5466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to have been added in 825bfdb0a9c53cf71cdec349eb1e2b6b47b951ca
to prevent stopping a Sound before it's started, as it can take up to 0.5s to start. But this method means Sound components with duration <0.5s play forever as
.stop
is never called. Better instead to check that t >= start + 0.5