Error got an unexpected keyword argument "reset" when trying to pause using PTB sounds
#5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key thing here is that although self.track.stop exists it doesn't
have the convenience of including the reset=True/False option so users
got an error:
```
...backend_ptb.py line 539, in pause
self.track.stop(reset=False)
TypeError: stop() got an unexpected keyword argument "reset"
```
Codecov Report
@@ Coverage Diff @@
## release #5619 +/- ##
===========================================
- Coverage 43.15% 43.15% -0.01%
===========================================
Files 313 313
Lines 58547 58550 +3
===========================================
+ Hits 25264 25265 +1
- Misses 33283 33285 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pause was calling
self.track.stopnotself.stopself.track.stopis a lower level function and doesn't have the convenience of including the reset=True/False option so users got an error: