-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy types support #332
Merged
Merged
Numpy types support #332
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
15fbcd6
feat: add numpy dumpers for int, float, bool types
vertefra 0a48098
test(numpy): fix skipping tests if numpy module is not installed
dvarrazzo 9387e91
refactor(numpy): use existing numeric base classes
dvarrazzo 5a10126
test(numpy) fix tests with approximative comparisons
dvarrazzo 17fa4ce
refactor(numpy): use builtin bool dumpers for numpy booleans too
dvarrazzo 08be8c5
refactor(numpy): drop aliases for dumpers
dvarrazzo 91137e5
refactor(numpy): reuse base or final classes from builtin numeric types
dvarrazzo d04b713
feat(numpy): add longlong dumpers
dvarrazzo 7c297ae
test(faker): don't crash if a lazy-import dumper class is not available
dvarrazzo fd5e175
test(numpy): consolidate all numpy int tests in a single parametrized…
dvarrazzo ab6ec9d
test(numpy): add random tests with numpy objects
dvarrazzo a74c66e
test(numpy): consolidate numpy float tests
dvarrazzo 7bd6330
fix(numpy): fix dumpers registration order
dvarrazzo b842daa
test(numpy): allow more approximation comparing float16 values
dvarrazzo 232ae28
test(numpy): add dump tests with list of numpy values
dvarrazzo 11d7666
test(numpy): drop test with deprecated alias
dvarrazzo c576c84
test(numpy) avoid overflow testing with int16
dvarrazzo 016a9bb
refactor(c): add _IntOrSubclass dumper to the C dumpers too
dvarrazzo 1aa47d5
docs: improve comment about why we need to register builtin numerics …
dvarrazzo e1f9420
feat: add C numpy dumpers
dvarrazzo 157a2e2
docs: add news entry and docs about numpy scalars support
dvarrazzo 73ab14d
refactor(numpy): get OIDs from the _oid module
dvarrazzo 15a75f9
fix(numpy): fix dumping numpy values by oid
dvarrazzo 40bb620
fix(copy): fix dumping by oid in text mode
dvarrazzo 29bb630
fix(c): don't try to mutate Cython type
dvarrazzo 92b30b0
feat(crdb): add numpy support
dvarrazzo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I really don't like the need of an isinstance per int dump.
Now that we have Enum dumpers, I would like to try if it's possible to associate a pure int dumper to ints (one that just assumes that str(obj) returns the number representation) and associate a dumper converting to int only to enums.