Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

Add ARM64 jobs in Travis-CI #14

Merged
merged 1 commit into from Jul 21, 2020
Merged

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Jul 20, 2020

Added ARM64 jobs in Travis-CI for building aarch64 wheels.

@odidev
Copy link
Contributor Author

odidev commented Jul 20, 2020

@dvarrazzo,

Please review and let me know if any changes required.

.travis.yml Outdated Show resolved Hide resolved
scripts/configure_postgres.sh Outdated Show resolved Hide resolved
scripts/build_libpq.sh Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
scripts/build_libpq.sh Outdated Show resolved Hide resolved
Copy link
Member

@dvarrazzo dvarrazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think this UNAME_M var is the last change I'd like to see landing in this MR 🙂

scripts/build_libpq.sh Outdated Show resolved Hide resolved
scripts/build_libpq.sh Outdated Show resolved Hide resolved
@dvarrazzo
Copy link
Member

This MR is ok this way 👍 Thank you very much!

I was thinking that this depends on the psycopg2 branch, but actually it doesn't: no change is needed to the code, we were only playing with the CI configuration.

The psycopg2 submodule in this branch is currently pointing to an untagged release: that's good. I will merge to master so we can check if upload works ok.

@dvarrazzo dvarrazzo merged commit 989140e into psycopg:master Jul 21, 2020
@odidev
Copy link
Contributor Author

odidev commented Jul 21, 2020

Thanks for merging the PR. May I know, When are you planning to make a release with aarch64 wheels to PyPI?

@dvarrazzo
Copy link
Member

Well, as the psycopg2 code didn't run any change, and the wheel package does its own testing of the built package by running the psycopg2 test suite, it wouldn't be a problem to add the arm packages to the current release 2.8.5 on PyPI. Or do you see any side effects in doing so?

@odidev
Copy link
Contributor Author

odidev commented Jul 21, 2020

Yes, there is no problem with adding arm wheels to the current release. Just asked, as we normally have a new release and upload wheels into PyPI. Thanks

@odidev
Copy link
Contributor Author

odidev commented Jul 21, 2020

@dvarrazzo,

Do we use the same repo for uploading psycopg2-binary wheels?

@dvarrazzo
Copy link
Member

Maybe a new release would be cleaner... Let's do this: I'm doing another work with psycopg2, and once that's finished I can release 2.8.6. If I see it's taking me too much (like, more than one week) then I will release arm packages for 2.8.5 and won't leave you wait too long. Otherwise I'll add arm to 2.8.6 and note in the news that the binary packages were only available from that release.

Does it work for you?

@dvarrazzo
Copy link
Member

Do we use the same repo for uploading psycopg2-binary wheels?

sorry, what do you mean here?

@odidev
Copy link
Contributor Author

odidev commented Jul 21, 2020

Maybe a new release would be cleaner... Let's do this: I'm doing another work with psycopg2, and once that's finished I can release 2.8.6. If I see it's taking me too much (like, more than one week) then I will release arm packages for 2.8.5 and won't leave you wait too long. Otherwise I'll add arm to 2.8.6 and note in the news that the binary packages were only available from that release.

Does it work for you?

Ok. No issues, you can add arm wheels to release 2.8.6.

@odidev
Copy link
Contributor Author

odidev commented Jul 21, 2020

Do we use the same repo for uploading psycopg2-binary wheels?

sorry, what do you mean here?

Actually, I am seeing 2 psycopg2 projects(psycopg2 and psycop2-binary) in PyPI. So, I just want to know whether wheels will be uploaded to both projects or any specific project.

@dvarrazzo
Copy link
Member

Hi @odidev

I think we need to reinstate the longer travis timeout: this job is failing: https://travis-ci.org/github/psycopg/psycopg2-wheels/jobs/710301936

The package is meant to be psycopg2-binary only. psycopg2 is source only (except on Windows). Binary packages by default have caused a long trail of misery (you can search for "wheel" issues in the psycopg2 bug tracker) so they are opt-in.

@odidev
Copy link
Contributor Author

odidev commented Jul 21, 2020

Do you want me to raise a new PR for this or maybe you can add travis_wait 30?

But I think it was working properly in this PR builds too. I am not sure why it is giving error now.

@dvarrazzo
Copy link
Member

I didn't remember what was the config parameter you used: it got lost in rebases. I can try and use it myself on master, thank you 🙂

@odidev
Copy link
Contributor Author

odidev commented Jul 21, 2020

I think it is failing even before starting the build. I suppose, this maybe Travis issue, there is no issue with our code.

@dvarrazzo
Copy link
Member

Yes, I added back the script timeout, but I've noticed it too, the pipeline fails before reaching that point 🤔

@odidev
Copy link
Contributor Author

odidev commented Jul 21, 2020

I have rechecked again in my local Travis, it is passing for me.
Report: https://travis-ci.org/github/odidev/psycopg2-wheels/builds/710225147

I am not sure why it is giving a timeout error here.

@dvarrazzo
Copy link
Member

Created a support request here: https://travis-ci.community/t/arm-job-timing-out-during-initialization/9403

@odidev
Copy link
Contributor Author

odidev commented Aug 25, 2020

@dvarrazzo,

Can you please re-trigger the builds to check whether the issue persists or not?

@odidev
Copy link
Contributor Author

odidev commented Sep 2, 2020

@dvarrazzo, may I know when the next release for psycopg2 is scheduled?

@dvarrazzo
Copy link
Member

I was planning to create a release before next week. I was asked for one for psycopg/psycopg2#996 too.

@odidev
Copy link
Contributor Author

odidev commented Sep 3, 2020

@dvarrazzo,

I think the Travis issue with arm64 build can be resolved if we use arm64-graviton2 and it is faster as well. But for using this as arch, travis needs to be migrated from travis.org to travis.com. For more details on migration, you can go through https://docs.travis-ci.com/user/migrate/open-source-repository-migration.

Please let me know if any more info is needed.

@dvarrazzo
Copy link
Member

Hi @odidev,

I don't have the bandwidth to look into it within this release: I don't know how much work would be.

If you wish you can add a ticket to remind us to move to travis.com, but I doubt it will happen in September.

Thank you for pointing it out!

@odidev
Copy link
Contributor Author

odidev commented Sep 4, 2020

Hi @odidev,

I don't have the bandwidth to look into it within this release: I don't know how much work would be.

If you wish you can add a ticket to remind us to move to travis.com, but I doubt it will happen in September.

Thank you for pointing it out!

Thanks for the reply.

I have raised a ticket #15 as mentioned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants