Conversation
Please review and let me know if any changes required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think this UNAME_M
var is the last change I'd like to see landing in this MR 🙂
This MR is ok this way 👍 Thank you very much! I was thinking that this depends on the psycopg2 branch, but actually it doesn't: no change is needed to the code, we were only playing with the CI configuration. The |
Thanks for merging the PR. May I know, When are you planning to make a release with aarch64 wheels to PyPI? |
Well, as the psycopg2 code didn't run any change, and the wheel package does its own testing of the built package by running the psycopg2 test suite, it wouldn't be a problem to add the arm packages to the current release 2.8.5 on PyPI. Or do you see any side effects in doing so? |
Yes, there is no problem with adding arm wheels to the current release. Just asked, as we normally have a new release and upload wheels into PyPI. Thanks |
Do we use the same repo for uploading psycopg2-binary wheels? |
Maybe a new release would be cleaner... Let's do this: I'm doing another work with psycopg2, and once that's finished I can release 2.8.6. If I see it's taking me too much (like, more than one week) then I will release arm packages for 2.8.5 and won't leave you wait too long. Otherwise I'll add arm to 2.8.6 and note in the news that the binary packages were only available from that release. Does it work for you? |
sorry, what do you mean here? |
Ok. No issues, you can add arm wheels to release 2.8.6. |
Actually, I am seeing 2 psycopg2 projects(psycopg2 and psycop2-binary) in PyPI. So, I just want to know whether wheels will be uploaded to both projects or any specific project. |
Hi @odidev I think we need to reinstate the longer travis timeout: this job is failing: https://travis-ci.org/github/psycopg/psycopg2-wheels/jobs/710301936 The package is meant to be |
Do you want me to raise a new PR for this or maybe you can add But I think it was working properly in this PR builds too. I am not sure why it is giving error now. |
I didn't remember what was the config parameter you used: it got lost in rebases. I can try and use it myself on master, thank you 🙂 |
I think it is failing even before starting the build. I suppose, this maybe Travis issue, there is no issue with our code. |
Yes, I added back the script timeout, but I've noticed it too, the pipeline fails before reaching that point 🤔 |
I have rechecked again in my local Travis, it is passing for me. I am not sure why it is giving a timeout error here. |
Created a support request here: https://travis-ci.community/t/arm-job-timing-out-during-initialization/9403 |
Can you please re-trigger the builds to check whether the issue persists or not? |
@dvarrazzo, may I know when the next release for psycopg2 is scheduled? |
I was planning to create a release before next week. I was asked for one for psycopg/psycopg2#996 too. |
I think the Travis issue with arm64 build can be resolved if we use arm64-graviton2 and it is faster as well. But for using this as arch, travis needs to be migrated from travis.org to travis.com. For more details on migration, you can go through https://docs.travis-ci.com/user/migrate/open-source-repository-migration. Please let me know if any more info is needed. |
Hi @odidev, I don't have the bandwidth to look into it within this release: I don't know how much work would be. If you wish you can add a ticket to remind us to move to travis.com, but I doubt it will happen in September. Thank you for pointing it out! |
Thanks for the reply. I have raised a ticket #15 as mentioned. |
Added ARM64 jobs in Travis-CI for building aarch64 wheels.