Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rework psycopg2.connect() interface. #363
This might sound scary, but... I have some good reasons to move the
I've found it pity that the handy
referenced this pull request
Nov 2, 2015
added a commit
this pull request
Mar 3, 2016
I have been thinking about this branch, and I'm not convinced. The C implementation is way more complicated than a Python one, for no real benefit.
I have put together a pure Python implementation of
Thanks to the use of
@dvarrazzo hm... but can I really import your Python-defined
Thank you for looking into this! :-)
Yes, it's less frequent but it's no problem for the C part importing bits of Python: for some example grep for
As an advice, don't cache the imported module but deal with it as a normal Python object, dereferencing it at the end of the function. Importing a module already imported is a fast operation; not releasing it creates all sort of problems in environments where the Python interpreter is reloaded, because the C library is not (Federico will remember a lot of pain around
Thank you very much for your contribution and I apologise again for the long time taken to get back at your work: I've really appreciated your collaboration and even if this pull request didn't make in the library I think make_dsn/parse_dsn are a good addition, together with all your other Ideas.
All the best!