Make dbapi_extension.py compatible with Sphinx 1.6 #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Sphinx commit 1a821b89e9952fc2, the deprecated make_admonition() function was removed. This commit updates the code to use the modern API instead.
|
Hello, thank you for your MR! Could you please fix the Thank you very much |
|
It still works with older Sphinx too. Just old Sphinx contained some compat code for ancient docutils versions (like pre-2009), and new Sphinx does not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sphinx-doc/sphinx@1a821b89e9952fc2, the deprecated
make_admonition()function was removed.This pull request updates the code to use the modern API instead. Also
Directiveis imported fromdocutils.parsers.rst, as import fromsphinx.util.compatis deprecated since sphinx-doc/sphinx@2df0bb8d03d05fe7.