Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoscale axes when map_extent is None #12

Merged
merged 1 commit into from
Apr 22, 2020
Merged

autoscale axes when map_extent is None #12

merged 1 commit into from
Apr 22, 2020

Conversation

Chilipp
Copy link
Member

@Chilipp Chilipp commented Apr 22, 2020

This commit changes the behavious of the None value for the map_extent formatoption. Now, map_extent=None triggers a call of the plotter.ax.autoscale method, whereas the old behaviour was to use the lonlatbox of the lonlatbox formatoption. This causes problems for regional files close to the map-boundary (see #11).

The old behaviour can be retained by setting map_extent='data'

Closes #11

  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Fully documented, including CHANGELOG.rst for all changes

This commit changes the behavious of the None value for the map_extent formatoption. Now, map_extent=None triggers a call of the plotter.ax.autoscale method, whereas the old behaviour was to use the lonlatbox of the lonlatbox formatoption. This causes problems for regional files close to the map-boundary (see #11).

The old behaviour can be retained by setting map_extent='data'
@codecov-io
Copy link

Codecov Report

Merging #12 into master will decrease coverage by 0.91%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   86.93%   86.01%   -0.92%     
==========================================
  Files           5        5              
  Lines        1041     1037       -4     
==========================================
- Hits          905      892      -13     
- Misses        136      145       +9     
Impacted Files Coverage Δ
psy_maps/plotters.py 85.89% <100.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5604cab...c23e3d0. Read the comment docs.

@Chilipp Chilipp merged commit 201899c into psyplot:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem in displaying dateline crossing for rotated coordinates
2 participants