Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecustpt&cyanbug): bonusPerHour #1717

Merged
merged 1 commit into from Jan 31, 2024
Merged

fix(ecustpt&cyanbug): bonusPerHour #1717

merged 1 commit into from Jan 31, 2024

Conversation

hui-shao
Copy link

修复时魔的获取。

原站点配置文件的 selector 获取的是基础时魔,未考虑加成。故删除具体站点配置文件中的选择器,回退到 NP 架构的通用选择器(#outer td[rowspan]),即可正确获取。

已在本地测试。

@fzlins fzlins merged commit da5dae2 into pt-plugins:dev Jan 31, 2024
4 checks passed
@EasonWong0603
Copy link

我发布ecustpt时是正确展示时魔的 #1711
经过你的改动之后,我的两个站点时魔显示异常
image
image
image
该功能改动的意图是什么呢?是否经过了充分测试?请提供一下你这边的测试截图

@EasonWong0603
Copy link

如确认为改动异常,请求@fzlins 尽快回滚该commit

@hui-shao
Copy link
Author

hui-shao commented Feb 3, 2024

@EasonWong0603
改动意图:如前面提到,你编写的配置文件是用正则获取“你当前每小时能获取xxx个魔力值 (A = 413.4)”,这并不是最终的魔力值,因为没有考虑到加成之类的因素,最终时魔是以表格中的合计为准。

测试是正常的,截图如下:
2024-02-03_080454
2024-02-03_080519
2024-02-03_080535

上层的 NP 架构通用选择器应该是没有问题的,因为其它很多站点也在用,比如猫站。你那边再试试看,重新从 action 下载安装试试,看看是什么情况下会导致获取不到。

@EasonWong0603
Copy link

@hui-shao
我这边是在pre-release刚推送的v1.6.1.2535版本发现的,我也拉取了action的zip,和本地build的dist,问题同样存在
action:image
pre-release:image
本地yarn build版本:image

image image

@hui-shao
Copy link
Author

hui-shao commented Feb 3, 2024

@EasonWong0603 我知道原因了,上层选择器也是用正则匹配的。这个魔力值上千的时候,里面有个逗号,导致匹配时出错。
我时魔不够,你那边比较方便测试,可以修改一下这个文件的129行,在正则匹配前,先移除一下逗号

https://github.com/pt-plugins/PT-Plugin-Plus/blob/dev/resource/schemas/NexusPHP/config.json#L129

@fzlins
Copy link
Collaborator

fzlins commented Feb 3, 2024

@hui-shao 我这边是在pre-release刚推送的v1.6.1.2535版本发现的,我也拉取了action的zip,和本地build的dist,问题同样存在 action:image pre-release:image 本地yarn build版本:image

image image

已经修了试试最新的action

@hui-shao
Copy link
Author

hui-shao commented Feb 3, 2024

已经修了试试最新的action

我这边试了,正常。等 EasonWong0603 试试看,他时魔多,可以验证这个问题,哈哈

@EasonWong0603
Copy link

最新的action版本已正常,刚睡醒时间隔得有点久哈,感谢各位
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants