Use into {} instead of apply hash-map
#3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For huge maps, `apply` may cause OOM, because it will realize all the elements of the arglist seq, and construct an Object[] to hold them.
|
Hi Jerry, Thanks for the heads-up! I've made some changes for performance and have just pushed Please take a look and let me know if that solves the issue? Cheers! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use nippy in production and found an OOM issue caused by the deserialization of a huge map, after monitoring the application for a while, I found it is caused by nippy.
For huge maps,
applymay cause OOM, because it will realize all the elements of the arglist seq, and construct anObject[]to hold them.I changed this line and use
(into {} ...)instead of(apply hash-map ...), and it works. The OOM issue could be avoided by this.