Fixed bug with auto-expiring keys with no expiration time #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptarjan
added a commit
that referenced
this pull request
Jun 9, 2015
Fixed bug with auto-expiring keys with no expiration time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51.
Keys which do not specify an expiration time were being auto-expired due to a bug in my PR #48. The fix is to only set the expiration callback if the expiration time is actually a valid number. The test suite did not catch this because of the mocked timer. But I added a new test which would catch this issue in the future.
We should probably get a new release out so no one else upgrades and is broken.