fix: More robust logic to determine latest available Chrome version

Fixes #517
ptarmiganlabs · Mar 6, 2024 · 182c1fc · 182c1fc
1 parent b2310e6
commit 182c1fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/butler-sheet-icons.js b/src/butler-sheet-icons.js
@@ -43,7 +43,7 @@ const program = new Command();
                 if (!options.browserVersion || options.browserVersion === '') {
                     if (options.browser === 'chrome') {
                         // eslint-disable-next-line no-param-reassign
-                        options.browserVersion = 'stable';
+                        options.browserVersion = 'latest';
                     } else if (options.browser === 'firefox') {
                         // eslint-disable-next-line no-param-reassign
                         options.browserVersion = 'latest';
@@ -279,7 +279,7 @@ const program = new Command();
                     if (!options.browserVersion || options.browserVersion === '') {
                         if (options.browser === 'chrome') {
                             // eslint-disable-next-line no-param-reassign
-                            options.browserVersion = 'stable';
+                            options.browserVersion = 'latest';
                         } else if (options.browser === 'firefox') {
                             // eslint-disable-next-line no-param-reassign
                             options.browserVersion = 'latest';
@@ -362,7 +362,7 @@ const program = new Command();
             )
             .option(
                 '--browser-version <version>',
-                'Version (=build id) of the browser to install. Use "butler-sheet-icons browser list-installed" to see which browsers are currently installed.'
+                'Version (=build id) of the browser to install. Use "butler-sheet-icons browser list-installed" to see which browsers are currently installed. Leave empty or set to "latest" to get latest available version.'
             );
 
         // ---------

diff --git a/src/lib/browser/browser-install.js b/src/lib/browser/browser-install.js
@@ -65,7 +65,7 @@ const browserInstall = async (options, _command) => {
         }
 
         logger.info(
-            `Resolved browser build id: "${buildId}" for browser "${options.browser}" version "${options.browserVersion}"`
+            `Resolved browser build id: "${buildId}" for browser "${options.browser}" version "${options.browserVersion}" on platform "${platform}"`
         );
 
         // Ensure browser can be downloaded